Ignore derivations of BrowsableAPIRenderer in OpenAPI schema #7497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #7477 no? |
|
@carltongibson Well, sure, this PR implements a fix for #7477. |
|
Doh, yes super. I thought that was a PR looking earlier. Did you see the comment there about the test? |
|
Just to quote the comment there, since this PR should have added tests to ensure we don't have a regression in the future. From #7477 (comment)
|
akx
force-pushed
the
openapi-ignore-browsable-subclasses
branch
from
2289b3b to
456e71a
Compare
|
@carltongibson Sorry for the delay. Rebased and fleshed out the test :) |
carltongibson
approved these changes
Oct 12, 2020
|
Of course isort failed. Let's see if 5a9c6c5 fixes it. |
Merged
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
…7497) * Ignore derivations of BrowsableAPIRenderer in OpenAPI schema * Improve test_renderer_mapping test Co-authored-by: Carlton Gibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the BrowsableAPIRenderer has been subclassed, it wouldn't be correctly ignored by the OpenAPI Schema generator.
Fixes #7477