Skip to content

Overlooked translation in search.html #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

Overlooked translation in search.html #7551

merged 1 commit into from
Mar 9, 2021

Conversation

CasEbb
Copy link
Contributor

@CasEbb CasEbb commented Sep 27, 2020

Missing trans in the template for SearchFilter

@xordoquy
Copy link
Collaborator

I am unsure if that change would require to explicitly set a value="search" attribute to the button tag.
Thoughts ?

@CasEbb
Copy link
Contributor Author

CasEbb commented Sep 27, 2020

That would be meaningless since the <button> doesn't have a name attribute.

@tomchristie tomchristie merged commit 393f867 into encode:master Mar 9, 2021
stefanacin pushed a commit to stefanacin/django-rest-framework that referenced this pull request Mar 22, 2021
@CasEbb @stefanacin
Overlooked translation in search.html (encode#7551)
6b82ed2
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@CasEbb @sigvef
Overlooked translation in search.html (encode#7551)
2140b2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasEbb @xordoquy @tomchristie