Fix: authtoken.TokenProxy cannot be proxy when not installed #7442

[KPilnacek]

Used the first of solutions @kalekseev proposed in #7442 (comment)

[terencehonles]

I arrived independently at the other solution @kalekseev proposed. Either is probably fine to use from my point of view since I don't use the model and may not ever, but I think my solution of throwing ImproperlyConfigured when the TokenProxy class is instantiated might be a slightly better user experience.

[terencehonles]

If this is the solution that's picked, you may want to edit this to check that the two models do exist and that they are indeed abstract instead of just checking that the import works. That way if Django's implementation changes we'd be able to notice the difference and either remove the test or special case it depending on the supported version.

Either way, nice to have a test! I started searching for issues before writing a test and this will help me too 🙂

[terencehonles]

you probably want to put the final reload in a finally: block, that way the imports aren't messed up for a subsequent test. I ran into this issue while adding tests to my PR.

[tomchristie]

This seems to be sufficient to me, let's go with this.

[DeeeeLAN]

When do you expect a new release that will include this fix?

[sdebnath]

Can we get a git tag added for this version and a release updated on pypi?

https://pypi.org/project/djangorestframework/

Still shows 3.12.1 as being the latest.

[naggie]

I'm also eagerly awaiting the PyPi publish. Thanks for the fix!

[banagale]

@naggie @sdebnath Here's a line for your requirements.txt to patch in the new release direct from github:

Django==3.1.2
# ...
# Temporary DRF requirement for #7571
git+https://github.com/encode/[email protected]
# ...

[sdebnath]

Thanks @banagale - looking forward to the distribution update down the road.