Skip to content

Documentation: use retrieve instead of read for Viewset #7577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

Exifers
Copy link
Contributor

@Exifers Exifers commented Oct 5, 2020

Currently in the documentation, it says :
Viewsets [...] provide operations such as read, or update

but the word retrieve is used for read operations in DRF.

Actually, from what I understand actions can take any custom name in Viewsets, but I think it would be cool to have consistent naming for this introductory sentence.

@xordoquy xordoquy merged commit 9dc10d2 into encode:master Oct 5, 2020
@xordoquy
Copy link
Collaborator

xordoquy commented Oct 5, 2020

indeed, consistence is nice, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants