Updated dependencies #7589

smithdc1 · 2020-10-11T06:14:18Z

I've bumped all the dependency versions with the exception of Markdown. Bumping that version causes a test fail (separate PR incoming shortly).

The main change here is bumping Pytest to version 6.

adamchainz · 2020-10-12T17:25:42Z

requirements/requirements-optionals.txt

-django-filter>=2.2.0, <2.3
+pygments==2.7.1
+django-guardian==2.3.0
+django-filter>=2.4.0, <2.5


Why are some requirements semantically ranged, and others aren't? Seems like it would make sense to do them all.

adamchainz · 2020-10-12T17:26:12Z

requirements/requirements-codestyle.txt

@@ -1,7 +1,7 @@
 # PEP8 code linting, which we run on all commits.
-flake8==3.8.3
+flake8==3.8.4
 flake8-tidy-imports==4.1.0
 pycodestyle==2.6.0


Each minor flake8 release only works with one pycodestyle release. Imo you can remove this pin, since flake8 depends on pycodestyle - and many other requirements

Suggested change

pycodestyle==2.6.0

adamchainz · 2020-10-12T17:26:42Z

requirements/requirements-testing.txt

-pytest-cov>=2.7.1
+pytest>=6.1,<6.2
+pytest-django>=3.10.0,<3.11
+pytest-cov>=2.10.1


Add a max here, like the other semantic ranges, at least <3 ?

smithdc1 · 2020-10-12T19:26:05Z

I've widened some of the ranges:

isort has a commitment from 5.1 onwards not to break anything until 6.0
django-filter is likely to move to calver in the next release iirc. So bump allow up to 3.0 for now.
Pytest I've allowed up to v.7, the plugins also to their next major release as their changelogs all look trivial in recent releases.

I'm less sure about some of the others, we've seen breaking changes within Markdown 3.3 for example.

coreapi & corescheme are archived, so I've left those as pinned versions.

adamchainz

LGTM, just need to fix the conflict with markdown.

smithdc1 · 2020-12-29T09:02:29Z

@adamchainz hope you had a good Christmas! 🎅

Could I ask you for a (hopefully) final review of this?

auvipy · 2020-12-30T01:05:28Z

requirements/requirements-testing.txt

-pytest-cov>=2.7.1
+pytest>=6.1,<7.0
+pytest-cov>=2.10.1,<3.0
+pytest-django>=3.10.0,<4.0


pytest-django can be 4.1+

adamchainz · 2021-03-18T11:01:57Z

Sorry I forgot to come back to this @smithdc1 . Could you rebase to fix the conflict and show the latest tests still pass? Then I'd be happy to merge.

smithdc1 · 2021-03-20T22:15:24Z

Hi Adam,

A change in pygments version 2.7.3 causes a markdown test to fail.

I suspect this is due to the test containing invalid json. The test was added in #5462, and I can't tell if this was deliberate to get the output with errors. It's this line here that I think is incorrect.

django-rest-framework/tests/test_description.py

Line 29 in b25ac6c

"beta: "this is a string"

The image below shows the current output, the output with pygments>=2.7.3 and the output if I add a " to the json in the test.

I think we should adjust the test, but I'd appreciate your thoughts.

tomchristie · 2021-03-23T09:08:05Z

I think we should adjust the test, but I'd appreciate your thoughts.

Yup, agreed.

semantically ranged dependencies alpahetical order dependencies widen allowed version ranges Sorted imports with isort 5.8

adamchainz · 2021-04-05T09:27:57Z

It's green so I'll merge. But what happened to the markdown test change? Did a newer pygments release revert the change in output?

adamchainz · 2021-04-05T09:29:45Z

Also for future it could be convenient to move to a setup like I use on my repos: linting with pre-commit, pre-commit.ci running the tools and auto-updating them weekly, and test dependencies pinned with pip-compile, which I update fortnightly with a script.

smithdc1 · 2021-04-05T09:34:59Z

But what happened to the markdown test change?

I fixed it in #7892 👍

Thanks for the merge. 🎉

Following [my comment here](encode#7589 (comment)) and [Django's own move to pre-commit](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#pre-commit-checks). * Add pre-commit config file to run flake8 and isort. * Add extra "common sense" hooks. * Run pre-commit on GitHub actions using the [official action](https://github.com/pre-commit/action/). This is a good way to get up-and-running but it would be better if we activated [pre-commit.ci](https://pre-commit.ci/), which is faster and will auto-update the hooks for us going forwards. * Remove `runtests.py` code for running linting tools. * Remove `runtests.py --fast` flag, since that would now just run `pytest -q`, which can be done with `runtests.py -q` instead. * Remove tox configuration and requirements files for linting. * Update the contributing guide to mention setting up pre-commit.

adamchainz · 2021-04-05T10:27:11Z

Aha yes, great.

Following [my comment here](#7589 (comment)) and [Django's own move to pre-commit](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#pre-commit-checks). * Add pre-commit config file to run flake8 and isort. * Add extra "common sense" hooks. * Run pre-commit on GitHub actions using the [official action](https://github.com/pre-commit/action/). This is a good way to get up-and-running but it would be better if we activated [pre-commit.ci](https://pre-commit.ci/), which is faster and will auto-update the hooks for us going forwards. * Remove `runtests.py` code for running linting tools. * Remove `runtests.py --fast` flag, since that would now just run `pytest -q`, which can be done with `runtests.py -q` instead. * Remove tox configuration and requirements files for linting. * Update the contributing guide to mention setting up pre-commit.

Following [my comment here](encode#7589 (comment)) and [Django's own move to pre-commit](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#pre-commit-checks). * Add pre-commit config file to run flake8 and isort. * Add extra "common sense" hooks. * Run pre-commit on GitHub actions using the [official action](https://github.com/pre-commit/action/). This is a good way to get up-and-running but it would be better if we activated [pre-commit.ci](https://pre-commit.ci/), which is faster and will auto-update the hooks for us going forwards. * Remove `runtests.py` code for running linting tools. * Remove `runtests.py --fast` flag, since that would now just run `pytest -q`, which can be done with `runtests.py -q` instead. * Remove tox configuration and requirements files for linting. * Update the contributing guide to mention setting up pre-commit.

auvipy approved these changes Oct 12, 2020

View reviewed changes

adamchainz reviewed Oct 12, 2020

View reviewed changes

adamchainz approved these changes Oct 15, 2020

View reviewed changes

smithdc1 force-pushed the update_dependencies branch from 4865771 to 05fd4c2 Compare October 16, 2020 18:37

auvipy reviewed Dec 30, 2020

View reviewed changes

smithdc1 force-pushed the update_dependencies branch from 05fd4c2 to cd4fa83 Compare March 19, 2021 20:43

smithdc1 mentioned this pull request Mar 31, 2021

Fixed markdown test #7892

Merged

smithdc1 force-pushed the update_dependencies branch from cd4fa83 to e65aed0 Compare April 2, 2021 07:13

Updated dependencies

a8fece5

semantically ranged dependencies alpahetical order dependencies widen allowed version ranges Sorted imports with isort 5.8

smithdc1 force-pushed the update_dependencies branch from e65aed0 to a8fece5 Compare April 3, 2021 08:18

adamchainz merged commit d82519b into encode:master Apr 5, 2021

smithdc1 deleted the update_dependencies branch April 5, 2021 09:32

adamchainz mentioned this pull request Apr 5, 2021

Lint with pre-commit #7900

Merged

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022

Updated dependencies (encode#7589)

84aae12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Updated dependencies #7589

Updated dependencies #7589

smithdc1 commented Oct 11, 2020

Uh oh!

adamchainz Oct 12, 2020

Uh oh!

adamchainz Oct 12, 2020

Uh oh!

adamchainz Oct 12, 2020

Uh oh!

smithdc1 commented Oct 12, 2020

Uh oh!

adamchainz left a comment

Uh oh!

smithdc1 commented Dec 29, 2020

Uh oh!

auvipy Dec 30, 2020

Uh oh!

adamchainz commented Mar 18, 2021

Uh oh!

smithdc1 commented Mar 20, 2021

Uh oh!

tomchristie commented Mar 23, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

smithdc1 commented Apr 5, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

Uh oh!

Uh oh!

Updated dependencies #7589

Updated dependencies #7589

Conversation

smithdc1 commented Oct 11, 2020

Uh oh!

adamchainz Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

adamchainz Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

adamchainz Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

smithdc1 commented Oct 12, 2020

Uh oh!

adamchainz left a comment

Choose a reason for hiding this comment

Uh oh!

smithdc1 commented Dec 29, 2020

Uh oh!

auvipy Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

adamchainz commented Mar 18, 2021

Uh oh!

smithdc1 commented Mar 20, 2021

Uh oh!

tomchristie commented Mar 23, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

smithdc1 commented Apr 5, 2021

Uh oh!

adamchainz commented Apr 5, 2021

Uh oh!

Uh oh!