Skip to content

Bumped Markdown version to 3.3 #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Bumped Markdown version to 3.3 #7590

merged 3 commits into from
Oct 13, 2020

Conversation

smithdc1
Copy link
Contributor

Markdown version 3.3 changes the whitespace of the output.

Looking at the failing test it is suited to pass on multiple versions of Markdown. However, the tests are only run against the pinned dependency. Therefore I've simplified the test to only test against this one version.

Secondly, I've also added a pytest skip mark so it skips the test 'loudly'.

Final note, and more of a question really, most of the tests here are under a class which is subclass from TestCase however, all of the tests are written pytest style. Is there a reason for this, I guess it allows categorisation of the tests?

@adamchainz
Copy link
Contributor

I guess it allows categorisation of the tests?

And also the use of all of Django's TestCase features. Imo pytest with plain assert style and django TestCase classes give the best of both worlds.

@adamchainz
Copy link
Contributor

Looking at the failing test it is suited to pass on multiple versions of Markdown. However, the tests are only run against the pinned dependency. Therefore I've simplified the test to only test against this one version.

The test still runs on Python 3.5 / the old markdown?

@smithdc1
Copy link
Contributor Author

Hi Adam -- Yes, but the format is different on the slightly older version. I'll try and have a look later on but I'm thinking of making this along the lines of...

if PY == 3.5:
  do old thing
else: 
 do new thing

Or we could skip the test on Py3.5?

Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamchainz adamchainz changed the title Bumped Markdown version to version 3.3 Bumped Markdown version to 3.3 Oct 13, 2020
@adamchainz adamchainz merged commit 04e0c2b into encode:master Oct 13, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants