Skip to content

Reject PrimaryKeyRelatedField bool lookup values #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

amikrop
Copy link
Contributor

@amikrop amikrop commented Oct 15, 2020

In case maintainers intend to explicitly forbid bool values for PrimaryKeyRelatedField lookup.
Closes #7542

@tomchristie
Copy link
Member

Makes sense, yup.

@tomchristie tomchristie merged commit 67ebdd3 into encode:master Mar 17, 2021
stefanacin pushed a commit to stefanacin/django-rest-framework that referenced this pull request Mar 22, 2021
* Reject PrimaryKeyRelatedField bool lookup values

* Test PrimaryKeyRelatedField bool lookup rejection

* Fix indentation in test
@tomchristie tomchristie mentioned this pull request Mar 25, 2021
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
* Reject PrimaryKeyRelatedField bool lookup values

* Test PrimaryKeyRelatedField bool lookup rejection

* Fix indentation in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PrimaryKeyRelatedField Serializer Converts True Value Into ID and Succeeds
2 participants