Skip to content

Update throttling.md to provide context for granular throttling control through the action decorator #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

144mdgross
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing guidelines.

Description

There were recent updates to the @action decorator calling a little more attention to the kwargs it accepts.
I thought it would be useful to also provide an example in the throttling section of how those kwargs can be used to define/override throttle_classes through the action decorator as well.

There were recent updates to the `@action` decorator calling a little more attention to the kwargs it accepts. 
I thought it would be useful to also provide an example in the throttling section of how those kwargs can be used to define/override throttle_classes through the action decorator as well.
@144mdgross 144mdgross changed the title Update throttling.md Update throttling.md to provide context for granular throttling control through the action decorator Nov 2, 2020
@144mdgross
Copy link
Contributor Author

I just wanted to throw out there: this PR isn't a part of The DigitialOcean Hacktober that motivated people to submit so many one line PRs.
I had no idea that was a thing, and submitted this PR simply because I discovered this functionality by reading through the source code, and it proved very helpful. My co-workers were unaware of this functionality, so it felt important to update the docs with an example because there are probably a lot of people out there that don't realize the full potential here.
And my changes just happened to have been during October.
That's all and thanks for your work.

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 5, 2020

@144mdgross no problem, your contribution clearly isn't spam and needs some attention. I did not merge it because we recently slightly updated the action decorator documentation (though it's not pushed yet).
However, I think I'm fine since it's in the throttling page.

@xordoquy xordoquy merged commit 606df83 into encode:master Nov 5, 2020
@xordoquy
Copy link
Collaborator

xordoquy commented Nov 5, 2020

thanks for the contribution and sorry for the delay.

@144mdgross
Copy link
Contributor Author

thanks for the contribution and sorry for the delay.

No worries! Thanks @xordoquy for taking the time to check it out and merge! I appreciate your time!

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
There were recent updates to the `@action` decorator calling a little more attention to the kwargs it accepts. 
I thought it would be useful to also provide an example in the throttling section of how those kwargs can be used to define/override throttle_classes through the action decorator as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants