Allow 'get_page' method for overriding #7626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Wayper <[email protected]>
xordoquy
suggested changes
Nov 4, 2020
…ages Signed-off-by: Paul Wayper <[email protected]>
|
OK, I've updated the method name and it just converts to integer. Should we catch ValueErrors there? |
Signed-off-by: Paul Wayper <[email protected]>
tomchristie
pushed a commit
that referenced
this pull request
Mar 10, 2021
|
Closed in favour of #7652 |
stefanacin
pushed a commit
to stefanacin/django-rest-framework
that referenced
this pull request
Mar 22, 2021
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some instances, it may be necessary for subclasses to override the way the page number is resolved. This work implements a
get_pagemethod, like theget_page_sizemethod, to allow this to be overridden.This also enforces that page numbers must be greater than zero. Without this,
page=0and similar will return a 404.Signed-off-by: Paul Wayper [email protected]