Handle tuples same as lists in ValidationError detail context #7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seppeljordan
force-pushed
the
error-details-tuple
branch
2 times, most recently
from
001f312 to
95ba2ac
Compare
seppeljordan
force-pushed
the
error-details-tuple
branch
from
95ba2ac to
8d826d6
Compare
|
Hi, can I do anything from my side to accelerate the review process? |
|
@tomchristie @xordoquy Hi, is this wanted? Please let me know. |
|
Looks reasonable to me, yup. Thanks! |
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behavior of ValidationError slightly. Previously when handling details passed into the constructor, e.g. `ValidationError(detail=('message1', 'message2')) tuples got converted to strings. This means that the resulting JSON in the response looked similar to
instead of
which one might expect.
The described behavior might be unintuitive users. This is why after this PR would be merged, tuples would get the same treatment as lists in this regard, ergo result in outcome 2 instead of 1.