Skip to content

attempt to update pytest versions #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Dec 21, 2020

No description provided.

@auvipy auvipy mentioned this pull request Feb 16, 2021
@xordoquy
Copy link
Collaborator

I am afraid it's a bit early to drop Python 3.5 support. It is supported by Django 2.2 which is LTS until 2022.
Any reason we can't stick with the current pytest versions ?

@auvipy
Copy link
Member Author

auvipy commented Feb 16, 2021

if we explicitly use six and still update the versions everything will work. there is a related linked PR too

@auvipy
Copy link
Member Author

auvipy commented Feb 16, 2021

#7707

@auvipy auvipy closed this Feb 16, 2021
@auvipy auvipy reopened this Feb 16, 2021
@xordoquy
Copy link
Collaborator

xordoquy commented Feb 16, 2021

Well, pytest 6.2 release notes says they require 3.6+

@xordoquy
Copy link
Collaborator

ok, never mind. Python 3.5 is EOL, let's just move forward.

@auvipy
Copy link
Member Author

auvipy commented Feb 16, 2021

IMHO drf master should 3.6+ but it's up to you. as a downstream extension keep supporting and EOL py version is a maintenance burden IMHO. can we somehow pull the master branch here through Github?

@xordoquy
Copy link
Collaborator

to rebase ? I don't think so. I'll do that later if it's not already done before

@auvipy
Copy link
Member Author

auvipy commented Feb 16, 2021

rebased

@auvipy auvipy closed this Jan 17, 2022
@auvipy auvipy deleted the patch-4 branch January 17, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants