-
-
Notifications
You must be signed in to change notification settings - Fork 7k
#7703 adding deprecations to release notes #7716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7703 adding deprecations to release notes #7716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good addition i believe
Hi, thanks for the contribution. Could you rename the link as |
Sure thing. Completed in the most recent commit. |
Thanks for taking the reigns on getting this PR done @nathanglover Another breaking change I found relates to https://github.com/encode/django-rest-framework/pull/6659/files , which fixes a bug but causes Essentially, if you're currently overriding Example:
Although it took me quite awhile to understand why this broke for us, it's a pretty deep edge case that's arguably our fault for toying with DRF internals. Even so, if you all agree, I might recommend we change:
To
I can submit a follow-up PR for this if needed |
Looks good thanks @nathanglover. |
* encode#7703 adding deprecations to release notes * encode#7703 - update link for gh6687
* encode#7703 adding deprecations to release notes * encode#7703 - update link for gh6687
Closes #7703
Adding the
detail_route
andlist_route
deprecations to the 3.10.x release notes. Let me know if I need to update the format at all.