-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Remove a bit of inline CSS. Add CSP nonce where it might be required and is available. #8783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and is available.
{% get_pagination_html paginator %} | ||
</nav> | ||
{% endif %} | ||
|
||
<div class="request-info" style="clear: both" aria-label="{% trans "request info" %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear: both
was already in request-info
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind sharing the screenshots please after this changes?
@auvipy Sorry for the delayed response. Here's before: |
@juspence @auvipy
I do not understand the reason for removing this support in this PR
If there is no
Which is a lie. |
This PR uses a bootstrap class for floats ( This means if the user overrides the default theme as documented, the clear is gone, and all content boxes get stacked horizontally. Solution: Description and paginator should be wrapped in a |
Would you mind sending a PR to fix this? |
(Copied from #7960, but nonce removed to avoid conflicts with user-defined policies)
Remove a few instances of inline CSS which could trigger Content Security Policies (CSPs) and replace with classes where required.
Part of #6069.
I've left JavaScript alone as it's covered by #5740 and #7016 (which I think are duplicates of each other?).