Fix FilePathField required argument #8805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auvipy Not sure what the CI error is. Seems that deprecation warnings are making it fail? |
|
can you please check why the CI is failing?? might be unrelated to this PR after checking the error message though |
|
I think we should get rid of python 3.6 now from CI |
|
@auvipy Also I wonder if setting Not sure of the expected behaviour though, as it is based on |
|
we should align with django mainly |
|
Waiting for CI fix on master. |
radekwlsk
force-pushed
the
fix-filepathfield-required
branch
from
cc50963 to
2bd0008
Compare
auvipy
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on the discussion in #8804 this PR fixes
requiredargument lost inFilePathFieldconstructor by making sure it is passed to thesuper().__init__call with other keyword arguments.