-
Notifications
You must be signed in to change notification settings - Fork 578
Upgrade and Deploy for 3.7 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @jpadilla. This is looking great. You should have Heroku access ≈today. After that, if there's anything else you need, ping me. I'm lining up DRF v3.7.4 for before the holiday break.encode/django-rest-framework#5650 That's a good target for this as well. Thanks for your effort! You rock! 🎸🤘🏽💃🏼🎉 |
@jpadilla Added you as a collaborator to the Heroku project. |
@carltongibson great, I'll make sure to tackle the rest of the things left before then. @tomchristie perf, thanks! I don't have enough permissions on this org, so I'll also need you to connect the app the repo, at the bottom here. |
So I think this is done! Before merging I'd love to finish setting up automatic deploys, but that will require @tomchristie connecting the app to the repo as it seems I don't have enough permissions on the encode org to do so. Once that's done, and this PR is approved, I'll merge, make sure deploy is working and setup the cleanup cron. |
@jpadilla Okay, I think that's done. Want to have a look, and then try merging this? |
@tomchristie I see the new pipeline, but I'm not seeing it connected to GitHub yet. Are you? |
@tomchristie bumping this up, can schedule to jump in a call if you'd like. |
Thanks so much @jpadilla. Should be connected now. (Sorry - not familiar with the pipeline UI.) |
Almost done with this. Heroku is having some issues today so taking a bit longer than what I hoped. |
Also, found some things to fix/improve in some of the tutorial sections(will open PR soon).