Skip to content

Add flag to enable processing and uploading of native symbols to Firebase servers. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/source/buildoptions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ options (this list may not be exhaustive):
project directory.
- ``--add-gradle-plugins``: Add a plugin for gradle. The format of the option
is ``<plugin-id>:<classpath>``. The option can be specified multiple times.
- ``--enable-crashlytics-native-symbol-upload``: Enable processing and uploading
of native symbols to Firebase servers. This flag must be enabled to see
properly-symbolicated native stack traces in the Crashlytics dashboard.


webview
Expand Down Expand Up @@ -162,6 +165,9 @@ ready.
project directory.
- ``--add-gradle-plugins``: Add a plugin for gradle. The format of the option
is ``<plugin-id>:<classpath>``. The option can be specified multiple times.
- ``--enable-crashlytics-native-symbol-upload``: Enable processing and uploading
of native symbols to Firebase servers. This flag must be enabled to see
properly-symbolicated native stack traces in the Crashlytics dashboard.


service_library
Expand Down
3 changes: 3 additions & 0 deletions pythonforandroid/bootstraps/common/build/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,9 @@ def parse_args_and_make_package(args=None):
ap.add_argument('--google-services-json', dest='google_services_json',
default='google-services.json',
help='Path to google-services.json file')
ap.add_argument('--enable-crashlytics-native-symbol-upload', dest='enable_crashlytics_native_symbol_upload',
action='store-true',
help='Enable processing and uploading of native symbols to Firebase servers.')
Comment on lines +892 to +894
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


# Put together arguments, and add those from .p4a config file:
if args is None:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ android {
{% if args.sign -%}
signingConfig signingConfigs.release
{%- endif %}
{$ if args.enable_crashlytics_native_symbol_upload -%}
firebaseCrashlytics {
nativeSymbolUploadEnabled true
}
{%- endif %}
Comment on lines +95 to +99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}

Expand Down