Skip to content

test: improve test coverage in a few areas #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2021
Merged

test: improve test coverage in a few areas #227

merged 1 commit into from
Nov 11, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Nov 11, 2021

Before

-----------------------------------|---------|----------|---------|---------|-------------------
File                               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------------------------------|---------|----------|---------|---------|-------------------
All files                          |   99.16 |     98.4 |   99.09 |   99.42 |

After

-----------------------------------|---------|----------|---------|---------|-------------------
File                               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------------------------------|---------|----------|---------|---------|-------------------
All files                          |   99.58 |    99.26 |   99.09 |   99.85 |

bmish
bmish commented Nov 11, 2021
View reviewed changes
lib/rules/prefer-output-null.js
}
return key === 'code' ? test : null;
return null;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change here. Just removing some dead codepaths that can't be hit for invalid test cases.

@aladdin-add aladdin-add merged commit 8bde9b4 into eslint-community:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmish @aladdin-add