Skip to content

chore: create CODEOWNERS #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: create CODEOWNERS #663

wants to merge 1 commit into from

Conversation

lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

In this PR, I’ve created a CODEOWNERS file.

Currently, reviewers are not assigned automatically when a user opens a PR. So, users have to do it manually, which sometimes leads to missing PRs since there is no notification.

I’ve added a CODEOWNERS file to address this issue and added @eslint/eslint-team.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 10, 2025
@lumirlumir lumirlumir requested a review from a team June 10, 2025 09:34
@lumirlumir lumirlumir mentioned this pull request Jun 10, 2025
97 tasks
@nzakas
Copy link
Member

nzakas commented Jun 10, 2025

Help me understand the purpose of this PR. Are you saying you're not receiving notifications from this repo?

@nzakas nzakas moved this from Needs Triage to Triaging in Triage Jun 10, 2025
@nzakas
Copy link
Member

nzakas commented Jun 11, 2025

I'm not sure we want to do this. We'll essentially be forcing everyone on the team to receive all notifications with no way to opt-out.

Thoughts @eslint/eslint-tsc

@nzakas nzakas mentioned this pull request Jun 11, 2025
1 task
@mdjermanovic
Copy link
Member

I also don't think this is necessary, as we can already click Watch -> All Activity to get notifications.

image

In eslint/eslint, we added this file to differentiate PRs that the website team can merge.

@mdjermanovic
Copy link
Member

Watch -> All Activity

Or, Watch -> Custom, and select Pull requests.

@nzakas
Copy link
Member

nzakas commented Jun 11, 2025

I think a better approach is to ensure all PRs end up on the Triage board, and then remind people that they should be using the Triage board in addition to notifications.

@lumirlumir
Copy link
Member Author

@nzakas @mdjermanovic Apologies for not clearly explaining my suggestion earlier.

The CODEOWNERS file is used in GitHub to define code ownership and automatically request reviews from the relevant team members when a pull request modifies the areas they are responsible for. It’s already being used in the eslint/eslint repository.

My original intention was to follow that existing convention and add a CODEOWNERS file to help clearly define who is responsible for reviewing pull requests. The automatic review requests are a helpful feature, but my main goal was to improve clarity around review responsibilities.

While the file may not be strictly required, it’s a common practice in many GitHub repositories and can contribute to better collaboration and maintenance.

Thank you for your time and consideration. I'm happy to follow the team's decision.

@fasttime
Copy link
Member

Today I learned what CODEOWNERS file are for :-) I've come across those files in a few repos before, but I never used them or took the time to look up what they do. If it's true that you can't opt out of GitHub notifications on a per-repo basis as a codeowner, I'm not in favor of this change.

@lumirlumir
Copy link
Member Author

Thanks to the TSC members for the opinions. Considering the comments, closing this PR as not planned.

@lumirlumir lumirlumir closed this Jun 12, 2025
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Jun 12, 2025
@lumirlumir lumirlumir deleted the lumirlumir-patch-1 branch June 12, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants