-
-
Notifications
You must be signed in to change notification settings - Fork 211
chore: create CODEOWNERS
#663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Help me understand the purpose of this PR. Are you saying you're not receiving notifications from this repo? |
I'm not sure we want to do this. We'll essentially be forcing everyone on the team to receive all notifications with no way to opt-out. Thoughts @eslint/eslint-tsc |
Or, Watch -> Custom, and select Pull requests. |
I think a better approach is to ensure all PRs end up on the Triage board, and then remind people that they should be using the Triage board in addition to notifications. |
@nzakas @mdjermanovic Apologies for not clearly explaining my suggestion earlier. The My original intention was to follow that existing convention and add a CODEOWNERS file to help clearly define who is responsible for reviewing pull requests. The automatic review requests are a helpful feature, but my main goal was to improve clarity around review responsibilities. While the file may not be strictly required, it’s a common practice in many GitHub repositories and can contribute to better collaboration and maintenance. Thank you for your time and consideration. I'm happy to follow the team's decision. |
Today I learned what CODEOWNERS file are for :-) I've come across those files in a few repos before, but I never used them or took the time to look up what they do. If it's true that you can't opt out of GitHub notifications on a per-repo basis as a codeowner, I'm not in favor of this change. |
Thanks to the TSC members for the opinions. Considering the comments, closing this PR as not planned. |
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
In this PR, I’ve created a
CODEOWNERS
file.Currently, reviewers are not assigned automatically when a user opens a PR. So, users have to do it manually, which sometimes leads to missing PRs since there is no notification.
I’ve added a
CODEOWNERS
file to address this issue and added@eslint/eslint-team
.Related Issues
Is there anything you'd like reviewers to focus on?