Skip to content
This repository was archived by the owner on Aug 9, 2022. It is now read-only.

Use crate::target pattern #37

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Use crate::target pattern #37

merged 2 commits into from
Jun 15, 2020

Conversation

fmckeogh
Copy link
Contributor

The HAL should ideally re-export the PAC so that users of the library don't have to include both crates. target is used instead of esp32 to match other HALs to make it easier to write cross-platform software.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a good idea, mind quickly updating the examples to use the take API? Then we should be good to go :)

@fmckeogh
Copy link
Contributor Author

@MabezDev Done!

@MabezDev
Copy link
Member

Perfect, thanks!

@MabezDev MabezDev merged commit 845676e into esp-rs:master Jun 15, 2020
@fmckeogh fmckeogh deleted the feat_target branch June 15, 2020 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants