This repository was archived by the owner on Aug 9, 2022. It is now read-only.
Blocking I2C #55
Merged
Blocking I2C #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'll take this out for a spin this weekend! |
|
Hey @MabezDev, friendly bump :) |
MabezDev
suggested changes
Apr 4, 2021
There was a problem hiding this comment.
@hanhossain my deepest apologies, I started this review and got side tracked by other things. I just had a few comments on the actual implementation. Unfortunately I have not yet had the chance to try this on actual hardware, but I will do this as soon as possible.
|
Perfect! Thanks for the contribution @hanhossain! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the changes made in #26 and adds onto them. Tested with the SSD1306 (using the Heltec LoRa 32 board) and the MPU6050.
Thank you @fmckeogh for the groundwork!