Skip to content

Make mkdir.py work under python3 versions below 3.5 #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 9, 2021
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions tools/mkdir.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,33 @@
import pathlib
import sys

def IsPythonVersionBelow3_5():
v = sys.version_info
if v[ 0 ] > 3 or ( v[ 0 ] == 3 and v[ 1 ] > 4 ):
return False
return True

def mkdir_3_4( p, parents_ ):
try:
pathlib.Path( p ).mkdir( parents = parents_ )
except FileExistsError:
pass

def mkdir_3_5( p, parents_ ):
pathlib.Path( p ).mkdir( parents = parents_, exist_ok = True )

def main():
parser = argparse.ArgumentParser(description='Platform-independent `mkdir`')
parser.add_argument('-p', '--parents', action='store_true', required=False, help='no error if existing, make parent directories as needed')
parser.add_argument('dir', action='store', nargs='+')
ns = parser.parse_args()
for p in ns.dir:
pathlib.Path(p).mkdir(parents=ns.parents, exist_ok=True)
return 0
parser = argparse.ArgumentParser(description='Platform-independent `mkdir`')
parser.add_argument('-p', '--parents', action='store_true', required=False, help='no error if existing, make parent directories as needed')
parser.add_argument('dir', action='store', nargs='+')
ns = parser.parse_args()
if IsPythonVersionBelow3_5():
mkdir_ = mkdir_3_4
else:
mkdir_ = mkdir_3_5
for p in ns.dir:
mkdir_( p, ns.parents )
return 0

if __name__ == '__main__':
sys.exit(main())
sys.exit(main())