Skip to content

feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

i3water
Copy link
Contributor

@i3water i3water commented Jun 6, 2025

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes


Description of Change

update wifiduinov2&wifiduino32s3 boards setting

Tests scenarios

All example codes were verified on the wifiduinov2&wifiduino32s3 board base on Arduino SDK v3.2.0, confirming functionality across different scenarios.

Related links

product link:
https://www.openjumper.com/doc/wifiduino-v2
https://www.openjumper.com/doc/wifiduino32s3

@i3water i3water requested a review from P-R-O-C-H-Y as a code owner June 6, 2025 02:59
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix wifiduinov2&wifiduino32s3 build board error.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "update wifiduinov2&wifiduino32s3 boards setting":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello i3water, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7c4bb86

@i3water i3water changed the title update wifiduinov2&wifiduino32s3 boards setting feat(boards): update wifiduinov2&wifiduino32s3 boards setting Jun 6, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL on my comment.
Please also share the boards data sheets or links so I can confirm some settings.

Comment on lines 31587 to +31592
wifiduino32c3.menu.FlashMode.dio=DIO
wifiduino32c3.menu.FlashMode.dio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.dio.build.boot=dio
wifiduino32c3.menu.FlashMode.qio=QIO
wifiduino32c3.menu.FlashMode.qio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.qio.build.boot=qio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wifiduino32c3.menu.FlashMode.dio=DIO
wifiduino32c3.menu.FlashMode.dio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.dio.build.boot=dio
wifiduino32c3.menu.FlashMode.qio=QIO
wifiduino32c3.menu.FlashMode.qio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.qio.build.boot=qio
wifiduino32c3.menu.FlashMode.qio=QIO
wifiduino32c3.menu.FlashMode.qio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.qio.build.boot=qio
wifiduino32c3.menu.FlashMode.dio=DIO
wifiduino32c3.menu.FlashMode.dio.build.flash_mode=dio
wifiduino32c3.menu.FlashMode.dio.build.boot=dio

You should keep the old order. With the current settings you use by default the QIO as:

wifiduino32c3.build.flash_mode=dio
wifiduino32c3.build.boot=qio

@@ -31513,23 +31513,26 @@ wifiduino32c3.build.target=esp
wifiduino32c3.build.mcu=esp32c3
wifiduino32c3.build.core=esp32
wifiduino32c3.build.variant=wifiduinov2
wifiduino32c3.build.board=WiFiduinoV2
wifiduino32c3.build.board=WIFIDUINOV2
wifiduino32c3.build.bootloader_addr=0x0

wifiduino32c3.build.cdc_on_boot=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the preferred (default) CDC mode.

Suggested change
wifiduino32c3.build.cdc_on_boot=0
wifiduino32c3.build.cdc_on_boot=1

Comment on lines 31636 to +31639
wifiduino32c3.menu.EraseFlash.all=Enabled
wifiduino32c3.menu.EraseFlash.all.upload.erase_cmd=-e
wifiduino32c3.menu.EraseFlash.none=Disabled
wifiduino32c3.menu.EraseFlash.none.upload.erase_cmd=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather keep the old defaults to not erase whole flash every time. Most of the time it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants