Added support for 8-bit grayscale output to fmt2bmp() for frame2bmp() #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
requested changes
Aug 12, 2022
There was a problem hiding this comment.
@devellison Thanks for the PR. The change looks reasonable, I have left some minor comments about the code.
conversions (reduces memory use for grayscale). Cleanup / Addressing PR suggestions
devellison
force-pushed
the
grayscale_fixes
branch
from
7caf4c5 to
73ed44b
Compare
|
Thanks @igrr ! Made the requested changes and updated the branch, let me know if there's anything else that needs adjustments. |
igrr
approved these changes
Aug 15, 2022
|
I'll keep this open for a bit in case @me-no-dev wants to review this — he is much more familiar with the codebase than I am. |
|
Thanks @devellison ! Changes look good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces memory use for grayscale output.