fix: flutter 3.29.x Parsing error(s): [(321..325): Doc directive 'nodoc' is unknown. #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
sky_engine
During Package Parsing in CLI CompileSummary
This PR updates the Dart Eval CLI compiler to skip the
sky_engine
package during the package parsing phase.sky_engine
is an SDK-internal package that does not need to be parsed or compiled, and including it leads to unnecessary processing or potential path resolution errors.Changes Made
sky_engine
when iterating over packages inpackage_config.json
.Code Highlight
Why I skipped sky engine ?
The
sky_engine
package is part of the Dart SDK internals and is marked with a@nodoc
annotation, which causes dart_eval to throw thenodoc
exception which is quite confusing to a user.To checkout the
nodoc
annotated file check it out on any 3.29 distribution onpackage:sky_engine/concurrent/concurrent.dart
Did I test my patch ?
Yes tested on both Linux Desktop and Android emulator and everything works as expected on 3.29.3