BAEL-9317 Parsing JSON boolean Value in Java - improve to talk about 0/1 representation #18573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
reviewed
May 28, 2025
json-modules/json/src/test/java/com/baeldung/jsonjava/ParseJsonBooleanUnitTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Test | ||
| void givenJSONString_whenParsed_correctBooleanValueReturned() { | ||
| String jsonString = "{\"name\":\"lorem ipsum\",\"active\":true,\"id\":1}"; |
There was a problem hiding this comment.
Please use text blocks for JSON.
Also, consider defining a member variable template since most of these tests have the same construct:
private final String json = """
{
"name": "lorem ipsum",
"active": %s,
"id": %d
}""";| void givenJSONWithBooleanAs0Or1_whenParsed_correctBooleanValueReturned() { | ||
| String jsonString = "{\"name\":\"lorem ipsum\",\"active\":1,\"id\":1}"; | ||
| JSONObject jsonObject = new JSONObject(jsonString); | ||
| int activeInt = jsonObject.getInt("active"); |
There was a problem hiding this comment.
From the guidelines:
when creating complex assertions, it’s a good idea to use assertj to preserve clarity - if assertions are trivial, it’s fine to stick to JUnit ones
If you do this, then the test becomes:
assertThat(jsonObject.getInt("active").isEqualTo(1);which is quite succinct.
KevinGilmore
reviewed
Jun 8, 2025
Comment on lines
42
to
43
| assertEquals(type,"Feature"); | ||
| assertEquals(geometry,"Point"); |
There was a problem hiding this comment.
Please reverse the order of the arguments. It's intended to be assertEquals(expected, actual)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.