Skip to content

protein-translation: Remove repetition from canonical data #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2017
Merged

protein-translation: Remove repetition from canonical data #1016

merged 3 commits into from
Nov 21, 2017

Conversation

sjwarner-bp
Copy link
Contributor

I noticed there was some redundancy in the test names - removed it 🙂

@sjwarner-bp
Copy link
Contributor Author

I wasn't sure if it was a big enough change to bother updating the version number or not - I'd be interested to hear thoughts.

ErikSchierboom
ErikSchierboom requested changes Nov 20, 2017
View reviewed changes
exercises/protein-translation/canonical-data.json Outdated
"property": "proteins",
"strand": "UGGUAGUGG",
"expected": ["Tryptophan"]
},
{
"description": "Translation stops if codon in middle of sequence of six-codon sequence",
"description": "Translation stops if codon in middle of six-codon sequence",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "Translation stops if codon" be "Translation stops if STOP codon"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is indeed the case - good spot! I'll fix that one too 🙂

@rpottsoh rpottsoh changed the title Remove repetition in problem-specification.json protein-translation: Remove repetition from canonical data Nov 20, 2017
@coriolinus
Copy link
Member

coriolinus commented Nov 20, 2017 •
edited
Loading

@sjwarner-bp re: increment the version?

It's a matter of discretion, really. The Semantic Version 2.0 spec says that the PATCH field is for "backwards-compatible bug fixes"; this is certainly backwards-compatible, but is it a bug fix?

My instinct is to say that as this change might change the output of exercise generators, you may as well update the patch field of the version. However, I don't feel strongly about this at all; I'm happy to leave it to your discretion.

I should have looked in the repo README, which specifically lists "Changing descriptions or comments" as requiring a PATCH version update. Per project standards, yes, you must update the version.

@sjwarner-bp
Copy link
Contributor Author

On it 👍

@coriolinus coriolinus merged commit 1146777 into exercism:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@Insti Insti Insti approved these changes

@rpottsoh rpottsoh rpottsoh approved these changes

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjwarner-bp @coriolinus @ErikSchierboom @Insti @rpottsoh @sjwarner