Skip to content

bob: Modify test case to include acronym in shouting #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

m-dango
Copy link
Member

@m-dango m-dango commented Aug 9, 2018

Encountered a submission where someone was addressing OK and DMV as acronyms and excluding those specifically when checking for shouting.

@m-dango m-dango merged commit f8a7158 into exercism:master Aug 10, 2018
@m-dango m-dango deleted the bob-ok-shout branch August 10, 2018 09:47
petertseng pushed a commit to exercism/haskell that referenced this pull request Sep 12, 2018
Otherwise, a student may assume DMV isn't shouted.

Prerequisite to #713.

Addresses exercism/problem-specifications#1293.
sshine added a commit to exercism/sml that referenced this pull request Oct 9, 2018
This includes:
 - 1.0.0 -> 1.1.0: "Calm down, I know what I'm doing!" in [1].
 - 1.1.0 -> 1.2.0: No-op in [2]
 - 1.2.0 -> 1.2.1: "no letters" in [3].
 - 1.2.1 -> 1.3.0: "I HATE THE DMV" in [4].
 - 1.3.0 -> 1.4.0: Grammatical error in testdata in [5].

[1]: exercism/problem-specifications#1025
[2]: exercism/problem-specifications#1056
[3]: exercism/problem-specifications#1282
[4]: exercism/problem-specifications#1293
[5]: exercism/problem-specifications#1319
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 20, 2018
Relevant PRs:
- exercism/problem-specifications#1282
- exercism/problem-specifications#1293
- exercism/problem-specifications#1319

Appart from the new tests, some old tests were renamed / got their input
value modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants