Skip to content

Update tsconfig.json #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Update tsconfig.json #34

merged 3 commits into from
Oct 11, 2021

Conversation

James-N-M
Copy link
Contributor

@James-N-M James-N-M commented Oct 9, 2021

Issue [(https://github.com//issues/28)]

Updating tsconfig.json to allow users to use console.log() in the editor window to debug solutions.

Updating tsconfig.json to allow users to use console.log() in the editor window to debug solutions.
@James-N-M James-N-M requested a review from a team as a code owner October 9, 2021 20:11
@SleeplessByte
Copy link
Member

Does this solve the error, or we don't know?

@SleeplessByte
Copy link
Member

/format

@github-actions
Copy link
Contributor

The "Format code" action has started running.

@github-actions
Copy link
Contributor

The "Format code" action has finished running.

@github-actions
Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@James-N-M
Copy link
Contributor Author

I didn't get to test it properly, I may need some help running the project.

@SleeplessByte
Copy link
Member

SleeplessByte commented Oct 11, 2021

Can you attempt to fix the CI by removing src/declarations.d.ts? (the one with type Window = undefined)

@SleeplessByte
Copy link
Member

The quickest way to test is probably:

  1. get the checks green
  2. have me merge it
  3. wait ~2-10 minutes for it to deploy
  4. try it on the live site :D

@James-N-M
Copy link
Contributor Author

Do you want me to delete the file src/declarations.d.ts ?? then commit that change, also can you add the hacktoberfest-accepted label to this pr :)

This file is causing problems with running the CI on this branch.
@SleeplessByte SleeplessByte added hacktoberfest-accepted Make this PR count for hacktoberfest x:size/small Small amount of work labels Oct 11, 2021
@SleeplessByte SleeplessByte merged commit fc08871 into exercism:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Make this PR count for hacktoberfest x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants