Skip to content

Feature/122 add optional drag step prop #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 7, 2019
Merged

Feature/122 add optional drag step prop #125

merged 10 commits into from
Mar 7, 2019

Conversation

littlejustinh
Copy link
Contributor

I found a spot that dragStep was not updating the store when the component props were updated. I don't think this is a critical issue, but should resolve before I forget about it.

@littlejustinh
added a dragStep prop that mimics the logic of the step prop but only…
c503765 
… for drag/swipe events
@littlejustinh
Merge branch 'master' of https://github.com/express-labs/pure-react-c…
b634988 
…arousel into feature/122---add-optional-dragStep-prop
@littlejustinh
Fixed the tests that I foolishly broke
1e2d3a6
@littlejustinh
fixed package-lock, rollup config, and a linting error
2b633a2
@littlejustinh
updated readme and typings to include drag step
9d6f730
@littlejustinh
filtered dragStep from CarouselProvider props
5a1424a
@littlejustinh
Updated all build files
b962699
@littlejustinh
added dragStep into componentWillReceiveProps updating the store state
de281a1
@littlejustinh
ran the build
8acf181
@littlejustinh
Merge branch 'master' of https://github.com/express-labs/pure-react-c…
f55f408 
…arousel into feature/122---add-optional-dragStep-prop

# Conflicts:
#	dist/index.cjs.js
#	dist/index.cjs.js.map
#	dist/index.es.js
#	dist/index.es.js.map
#	dist/react-carousel.cjs.css.map
@blmooredev blmooredev requested a review from mrbinky3000 March 7, 2019 13:36
@tim-steele tim-steele merged commit 1f1711f into master Mar 7, 2019
@littlejustinh littlejustinh deleted the feature/122---add-optional-dragStep-prop branch March 7, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmooredev blmooredev blmooredev approved these changes

@cvols cvols cvols approved these changes

@mrbinky3000 mrbinky3000 Awaiting requested review from mrbinky3000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@littlejustinh @blmooredev @cvols @tim-steele