Update Slider.jsx #146
Merged
Update Slider.jsx #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blmooredev
approved these changes
May 9, 2019
mrbinky3000
added a commit
that referenced
this pull request
May 9, 2019
* passing through events on Slider Component A goal of the project is to pass through all props when possible. We forgot to pass through event handlers on the slider component. * updated packages to silence rollup warnings Needed to update some rollup plugins after recent update to rollup. These plugins were using deprecated rollup hooks. * passing through props to slider Tray tag There was a request to pass through props to the Tray tag in slider. * Update Slider.jsx (#146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind the callback in the constructor?