Feature/dotgroup tuning #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to always allow the click on dots on DotsGroup if needed
tim-steele
approved these changes
Jun 25, 2019
|
@arnaudambro thank you! I published this out in version v1.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableActiveDots
Current behaviour
When a dot is shown as selected, it is disabled. So when two slides are visibles, one is fully visible and the other one is partially visible, we can't click on the dot corresponding to the partially visible slide.
Improved behaviour
This new prop does not change the default behaviour (so no breaking change), but it adds the option to let the dots enabled whatever, even if the slide is already visible.
showAsSelectedForCurrentSlideOnly
Current behaviour
For now, the dots are shown as selected is the slide is visible, so there might be several dots shown as selected. We can also want to show the dot as selected for the current slide only.
Improved behaviour
This new prop does not change the default behaviour (so no breaking change), but it adds the option to show the dot as selected for the current slide only.