Feature/pass through drag callbacks #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 13, 2019 13:38
These names were misleading. They are not related in any way to React’s event types.
Not sure why we are stopping event propagation in the slider tray. We should allow events to bubble up to maximize configurability for Pure React Carousel consumers. Commenting out for now, will remove completely if no bugs arise from this change.
Created a new example carousel to demonstrait how to pass events to the Slider tray element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, this code was created to address #155 "onDragStart events don't fire when dragging slider" However, it turns out that drag events are not firing for another reason entirely that isn't due to an error in our code.
Added example carousel 11, a new carousel that demonstrates how to attach event handlers to the slider tray tag.
Removed stopPropagation() calls from our internal event handlers. Not sure why they were added. Removing these didn't seem to affect the demos. Allowing the events to propagate increases the customizability of our carousel components.
Lastly, I renamed some misleading class method names relating to drag start and end. These methods had nothing to do with React's onDragStart and onDragEnd synthetic events. The names confused developers.