feature: infinite scroll works with swiping as well as buttons #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, thanks @mariohoyos92! @tim-steele or @mrbinky3000 would you like to take a look at this before we merge it? @allcontributors please add @mariohoyos92 for code |
|
I've put up a pull request to add @mariohoyos92! 🎉 |
|
How does everyone feel about this as a user experience? Swipe right and it jumps all the way back to the beginning of the slide show? Feels like a bug. I would like this better if I could turn this on/off for swipe. My gut says someone will complain about this in the future. |
tim-steele
approved these changes
Nov 13, 2019
|
Thanks @mariohoyos92 - we published [email protected] with the update. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
There was a recent addition to allow infinite scrolling with the buttons and with autoplay, but this isn't currently happening when a user swipes at the start or end of the carousel. This PR changes that.
Why:
When a user is swiping through pictures and hits the end of the carousel, it is cumbersome to have to swipe back through all of the photos instead of continuing to swipe forward.
How:
Modifying the computeCurrentSlide to account for when infinite is set to true.
Checklist:
Love what the team is doing with this! Thank you for the great package!