Updates for React.StrictMode compliance #205
Conversation
|
Thanks very much for doing this. However two tests are failing. |
|
Awesome, thanks @shoeman22! @allcontributors, please add @shoeman22 for code. |
|
I've put up a pull request to add @shoeman22! 🎉 |
|
@mrbinky3000 @bcarroll22 ok, I updated the CarouselProvider to accommodate test properly. Sorry for the noise in the commits -- I'd pushed to my own fork with Thanks for the shoutout on the contributors as well! |
There was a problem hiding this comment.
I'll wait for @mrbinky3000 to give the final approval before merging, but looks good to me 👍
|
@allcontributors, please add @shoeman22 for code. |
|
I've updated the pull request to add @shoeman22! 🎉 |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
When used within a
<React.StrictMode />block, this library was generating warnings since it was using the Legacy Context API. This PR updatesCarouselProviderandWithStoreto use the New Context API as recommended by react.There was also another strict mode warning with regard to using setState firing on an unmounted component, so I moved the subscribe step in the
Wrappercomponent inWithStoretocomponentDidMount()to correct this warning.Why:
I want to try out Concurrent Mode and the React team recommends making sure your app works without warnings when in Strict Mode before giving it a go. This library was the last hiccup I needed to solve to be warning free.
How:
I forked the repo and made the changes.
Checklist:
Loving the library so far. Great work!