Skip to content

Fixed naming issue for ButtonNext types #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fixed naming issue for ButtonNext types #211

merged 1 commit into from
Nov 20, 2019

Conversation

Hetachi
Copy link
Contributor

@Hetachi Hetachi commented Nov 20, 2019

Changed naming so that correct types are exported for ButtonNext

What:

Changed name from buttonNextInterface to buttonNextProps

Why:

It was incorrectly exporting interface instead of props

How:

Renamed exported type name

Checklist:

  • Documentation added/updated
  • Typescript definitions updated
  • Tests added and passing
  • Ready to be merged

Changed naming so that correct types are exported for ButtonNext
@mrbinky3000 mrbinky3000 merged commit c2e2a07 into express-labs:master Nov 20, 2019
@bcarroll22
Copy link
Contributor

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tim-steele
Copy link
Contributor

@allcontributors, please add @Hetachi for code

@allcontributors
Copy link
Contributor

@tim-steele

I've put up a pull request to add @Hetachi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants