Skip to content

Prevent negative slide number #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

mrbinky3000
Copy link
Collaborator

What:

This prevents the current slide from becoming -1 during re-renders under certain conditions. This is a fix for issue #247

Why:

You shouldn't have a negative number slide.

How:

Updated CarouselProvider.jsx

Checklist:

  • Documentation added/updated N/A
  • Typescript definitions updated N/A
  • Tests added and passing
  • Ready to be merged

@mrbinky3000 mrbinky3000 merged commit d72d899 into master Mar 12, 2020
@mrbinky3000 mrbinky3000 deleted the bugfix/fix-negative-number-current-slide branch March 12, 2020 18:47
@bcarroll22
Copy link
Contributor

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants