fix: RTL support #267
Merged
fix: RTL support #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes the carousel functional, but just via overriding the direction
relying on a global attribute selector feels a bit hacky
|
@seleb It looks like there are some linting errors that need to be addressed?
|
|
lint errors have been addressed; is there any additional discussion or changes needed on this? |
tim-steele
approved these changes
Apr 23, 2020
|
@seleb you are good! Merged - it will be built and published. |
|
🎉 This PR is included in version 1.27.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds RTL support to fix #266
Why:
Allows the carousel content to be accessed when used on RTL pages, and updates the slide direction to match the direction of the text
How:
Adding
[dir="rtl"] &selectors which flips the slider such that the slides are reversed and it visually translates in the opposite direction, and also flips each slide such that their content is not reversed.Checklist:
The global attribute selector used to solve this issue feels a little hacky, but afaik there is no CSS-only solution which is more robust (the
:dirpseudo-selector would be nice, but it doesn't have wide browser support)