Closes #269 : make dot children prop optional

[zhongdeliu]

What:

Made children of Dot component optional

Why:

See issue #269 - when using Dot directly, there may no need to have any children

How:

Changed props and updated docs (hopefully :) )

Checklist:

• Documentation added/updated
• Typescript definitions updated (
• Tests added and passing
• Ready to be merged

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zhongdeliu]

.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zhongdeliu]

.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed becuase it has not had recent activity.

[zhongdeliu]

pretty disappointing...

[tim-steele]

@zhongdeliu why would we make this optional? Wouldn't we just exclude the dots?

[zhongdeliu]

@tim-steele for our use case we wanted the dots and the button element with the .dot class was totally sufficient. So why put an empty string/jsx tag in there....

So is the intention to make the children prop optional

[tim-steele]

@allcontributors please add @zhongdeliu for code

[allcontributors]

@tim-steele

I've put up a pull request to add @zhongdeliu! 🎉

[bcarroll22]

🎉 This PR is included in version 1.27.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀