Skip to content

Add missing className for ButtonPlayProps typing #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add missing className for ButtonPlayProps typing #290

merged 1 commit into from
Sep 2, 2020

Conversation

zaruda
Copy link
Contributor

@zaruda zaruda commented Jul 29, 2020

What:

Added missing className typing for ButtonPlayProps interface

Why:

ButtonPlay has ability to set custom className (and its already documented)

How:

Changes were implemented for TS typings

Checklist:

  • Documentation added/updated (N/A)
  • Typescript definitions updated
  • Tests added and passing (N/A)
  • Ready to be merged

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that became stale label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically closed becuase it has not had recent activity.

@stale stale bot closed this Aug 15, 2020
@tim-steele tim-steele reopened this Sep 2, 2020
@stale stale bot removed the stale Issues that became stale label Sep 2, 2020
@tim-steele
Copy link
Contributor

@allcontributors please add @alecdwm for code

@allcontributors
Copy link
Contributor

@tim-steele

I've put up a pull request to add @alecdwm! 🎉

@tim-steele tim-steele merged commit a96c71c into express-labs:master Sep 2, 2020
@bcarroll22
Copy link
Contributor

🎉 This PR is included in version 1.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants