feat: Improve language picker UI with icons #1933
Open
+95
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ShubhamOulkar
changed the title
bjohansebas
reviewed
May 31, 2025
bjohansebas
reviewed
May 31, 2025
bjohansebas
reviewed
Jun 1, 2025
bjohansebas
reviewed
Jun 1, 2025
|
cool work, thanks for your contribution. |
ShubhamOulkar
commented
Jun 12, 2025
There was a problem hiding this comment.
Hi @bjohansebas, we can launch this pr. Flags rendering logic is changed in c37b3a4
LGTM 👍, I need approvals to launch these changes.
ShubhamOulkar
added
enhancement
design
bjohansebas
reviewed
Jun 12, 2025
| @@ -85,7 +85,10 @@ follow the specific instructions for [How to write a blog post.](https://express | |||
| **CSS or Javascript** | |||
| - All css and js files are kept in `css` and `js` folders on the project root. | |||
|
|
|||
| The Express JS website is built using [Jekyll](https://jekyllrb.com/) and is hosted on [Github Pages](https://pages.github.com/). | |||
| **SVG Flag Icons** | |||
| - The SVG flag icons used in this project were sourced from [Nucleo SVG Flag Icons.](https://nucleoapp.com/svg-flag-icons) | |||
There was a problem hiding this comment.
@expressjs/express-tc there's no problem referencing this, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
closes #1804
How SVG Icons Were Created?