This should make it clearer and more accurate in the case that PUBLIC_URL is blank. #1636
Conversation
This should make it clearer and more accurate in the case that PUBLIC_URL is blank, which is how I found it using one scaffolding tool.
Update index.html
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
| It will be replaced with the URL of the `public` folder during the build. | ||
| Only files inside the `public` folder can be referenced from the HTML. | ||
| Notice the use of the PUBLIC_URL variable in the tag above. It will | ||
| be (or has been) replaced with the URL of the `public` folder during |
There was a problem hiding this comment.
Maybe "will be (or has been)" -> "is"
|
|
||
| Unlike "/favicon.ico" or "favico.ico", "%PUBLIC_URL%/favicon.ico" will | ||
| work correctly both with client-side routing and a non-root public URL. | ||
| Unlike "/favicon.ico" or "favicon.ico", the link href path will, if |
There was a problem hiding this comment.
To be honest I don't think this is much clearer. Maybe we could provide some example?
There was a problem hiding this comment.
Sorry, I don't understand. Example of what, exactly?
Try again with wording, incorporating suggestions.
|
@gaearon any better? |
|
To be honest I don't find this to be much better. I'd leave the string as is. Thanks for the PR though! |
...which is how I found it using one scaffolding tool.