Skip to content

Fix a potential issue #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Fix a potential issue #2569

merged 1 commit into from
Jun 19, 2017

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jun 19, 2017

In the rare case that the environment variable has been defined as a non-string, we don't want to cause an error.

@Timer Timer added this to the 1.0.8 milestone Jun 19, 2017
@Timer Timer merged commit 31a4d14 into facebook:master Jun 19, 2017
@Timer Timer deleted the safe-check branch June 19, 2017 17:27
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants