Revert 1 master #957
Closed
Revert 1 master #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable timer mocking and enable verbose output.
* Creating a new app in the current directory * Fixed style mistakes
* Add Surge.sh to deploy instructions * Add it also to the Table of Contents
Thanks to @geowarin for the tip in facebook#401 (comment)
* Load favicon through html-loader. Fixes facebook#291. * Add test for *.ico in e2e test suite * Configure html-loader to process <link href="..."> * Address feedback on html-loader inclusion. * Place favicon.ico at the root of the build dir * Make comment style consistent between prod and dev webpack configs * Fix html-loader config in dev mode
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
* add off font format to loaders * add otf format support
This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue facebook#465 for more information about this.
Small typo line 572 "becasue" to "because"
According to the official SemVer FAQ, versioning should start at 0.1.0 (http://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase)
* Get latest version numbers of react and react-dom from npm before install. * Run separate npm installs for react, react-dom, and react-test-renderer. * Consolidate into a single npm install. * Fix misplaced parenthesis, add missing semicolon. * Add missing semicolon.
* Started using babel-preset-latest * Updated babel dependencies * Remove redundant babel-plugin-syntax-async-functions * Disabled redundant regenerator transform
…ng files in cra.sh & release.sh (facebook#861)
* Clean up e2e script * Link to local packages after ejecting
* Exit on any errors passed in build stats * Match console error output in start.js
facebook#878) * Disable ES2015 transforms based on node version using babel-preset-env * pass major version number for node to babel-preset-env instead of version string * use parseFloat() instead of parseInt() to parse node version * fixed style nits
* Update react-scripts dependencies to use jest 16 * Remove testRegex from Jest config (now default)
…ok#826) * Support passing scoped package names to --scripts-version arg * Factor out bitwise operator in indexOf test * Comment on stripping only version or tag from package name arg
…ok#856) * Dispose error overlay when linting errors have been corrected * Fixed spelling error * Minor style tweaks
* Create asset filenames mapping on the build output I use danethurber/webpack-manifest-plugin on Webpack production configuration to create a file named `asset-manifest.json` which contain a mapping of all asset filenames to their corresponding output file. `asset-manifest.json` will be located at the root of output folder. This'll resolve facebook#600 * Add an explanation for ManifestPlugin * Make webpack-manifest-plugin's version exact
…acebook#876) * Add supports for prelease tags version * Add comment to regex * Cut everything after the first -\d * Make semver version optional, so just package name get parsed correctly
Running tests with the `-u` flag is a more reliable way to upgrade, because the watch mode only runs tests for changed files.
* Added note about env server restart As discussed in [facebook#870](facebook#870) * Style nit
…ook#927) * Enable babel parameters/destructuring for all versions of Node * Add more descriptive comment explaining plugin use
* Update dependencies * Use published version of eslint-config-react-app for development We dogfood on our eslint-config-react-app by using it as our ESLint config, but installing it from the local folder causes problems when its peerDependencies are updated, because npm won't update it unless the version number changes. Use the published version for dogfooding so it can be installed from npm.
Enable no-webpack-loader-syntax rule in eslint-config-react-app.
This reverts commit 1ef6ea5.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.