🐛 Fix reactivity for @Provide
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facing-dev#80 This change fixes reactivity when using Provide/Inject. This previously didn't work, because we froze the provided value at `provide()` invocation time by just accessing `sample[name]`. This change automagically wraps any provided values in a `computed()` wrapper, which should update downstream injected values whenever the provider changes. This does two things of note: 1. It uses the Vue.js `computed()` function as demonstrated in the [docs][1] 2. It wraps *any* provided value in `computed()`, including `data`, which removes the need for the extra getter demonstrated in the docs, but is a departure from the "standard" Vue component Options API Note that to use this now requires setting `unwrapInjectedRef: true`. [1]: https://vuejs.org/guide/components/provide-inject.html#working-with-reactivity
alecgibson
commented
Aug 9, 2023
| }, { | ||
| global: { | ||
| config: { | ||
| unwrapInjectedRef: true, |
There was a problem hiding this comment.
@ruojianll I'm not sure how happy I am with this fix: this config needs to be set to get this to work properly, which isn't great
There was a problem hiding this comment.
https://vuejs.org/guide/components/provide-inject.html#working-with-reactivity
In vue 3.3 unwrapInjectedRef=true is a default config.
| const slot = obtainSlot(cons.prototype) | ||
| const names = slot.obtainMap('provide') | ||
| if (!names) return null | ||
| names.forEach((value, name) => { | ||
| const key = value === null ? name : value | ||
| optionBuilder.provide![key] = sample[name] | ||
| optionBuilder.provide![key] = computed(() => vueInstance[name]) |
There was a problem hiding this comment.
I don't know if we can do anything with optionBuild.computed instead of relying on the Vue.js computed() method?
There was a problem hiding this comment.
You are using in a documented vue3 way, that's good.
https://vuejs.org/guide/components/provide-inject.html#working-with-reactivity
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
This change fixes reactivity when using Provide/Inject. This previously didn't work, because we froze the provided value at
provide()invocation time by just accessingsample[name].This change automagically wraps any provided values in a
computed()wrapper, which should update downstream injected values whenever the provider changes.This does two things of note:
computed()function as demonstrated in the docscomputed(), includingdata, which removes the need for the extra getter demonstrated in the docs, but is a departure from the "standard" Vue component Options APINote that to use this now requires setting
unwrapInjectedRef: true.