StartParameters don't work on Windows

[hugodutka]

Each parameter is enclosed in single quotes, which the shell on Windows treats as regular characters rather than string delimiters. Embedded postgres then fails to start with:

waiting for server to start....2024-10-30 19:27:34.938 GMT [5368] FATAL:  invalid value for parameter "max_connections": "'1000'"
 stopped waiting
pg_ctl: could not start server
Examine the log output.
panic: could not start postgres using C:\Users\RUNNER~1\AppData\Local\Temp\coder-test-postgres\bin\bin\pg_ctl start -w -D C:\Users\RUNNER~1\AppData\Local\Temp\coder-test-postgres\data -o -p 5432 -c max_connections='1000':

As a workaround, one can use ALTER SYSTEM SET SQL queries for now.

[hugodutka]

@fergusstrange Would you be open to accepting a PR to fix this issue?

[fergusstrange]

Absolutely @hugodutka, I'm suprised this hasn't cropped up before!

If you could add some level of coverage in here https://github.com/fergusstrange/embedded-postgres/blob/master/platform-test/platform_test.go then these should automatically run (and fail on windows).

That should be enough to prove the value and fix suggested encoding method here

embedded-postgres/embedded_postgres.go

Line 205 in 7c0ced3

options = append(options, fmt.Sprintf("-c %s='%s'", k, v))

Let me know how you get on?

Cheers

[fergusstrange]

Release @ v1.30.0 thanks!