Skip to content

Fix type errors in Vite example app #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

zhougsoft
Copy link
Contributor

hello!
I was getting some minor TypeScript red squigglies in the Vite demo app that I was able to resolve with these changes. TS was complaining about accessing possible null refs (video & message) and data.buffer.

Since ffmpeg.readFile returns type FileData, seemed that the data needed to be cast as ArrayBuffer then converted to Uint8Array to access the buffer property.

I didn't see any contribution guidelines for the examples/misc stuff, sorry if this isn't how it's done 😅

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for ffmpegwasm canceled.

Name Link
🔨 Latest commit 9a3ce81
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/64dec8afeeba5f0008043194

@jeromewu
Copy link
Collaborator

Looks great! Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants