-
-
Notifications
You must be signed in to change notification settings - Fork 948
feat(ffmpeg): abort signal #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ffmpegwasm canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotating
@@ -85,7 +89,8 @@ export class FFmpeg { | |||
*/ | |||
#send = ( | |||
{ type, data }: Message, | |||
trans: Transferable[] = [] | |||
trans: Transferable[] = [], | |||
signal?: AbortSignal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a 3rd (optional) param
public load = (config: FFMessageLoadConfig = {}): Promise<IsFirst> => { | ||
public load = ( | ||
config: FFMessageLoadConfig = {}, | ||
{ signal }: FFMessageOptions = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for every methods using #send : add an options param to pass the optional signal
data: config, | ||
}, | ||
undefined, | ||
signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass the signal option to #send
LGTM, thanks! |
I can confirm having the same issue, after using controller.abort(), the previous executed command still on going. |
It doesn't work on my react app. |
This doesn't end the I think #719 should not be closed @ArsenicBismuth |
NB:
err
is a DOMException when aborting