Skip to content

Commit 7927184

Browse files
authored
Merge pull request #245 from peterhav/cleanup-auth-strings
Cleanup strings.xml: removed duplicates.
2 parents d5de444 + 76aada4 commit 7927184

File tree

6 files changed

+5
-11
lines changed

6 files changed

+5
-11
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackPasswordPrompt.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public class WelcomeBackPasswordPrompt extends AppCompatBase implements View.OnC
6060
@Override
6161
protected void onCreate(Bundle savedInstanceState) {
6262
super.onCreate(savedInstanceState);
63-
setTitle(R.string.sign_in_title);
63+
setTitle(R.string.sign_in);
6464
setContentView(R.layout.welcome_back_password_prompt_layout);
6565
mPasswordLayout = (TextInputLayout) findViewById(R.id.password_layout);
6666
mIdpResponse = getIntent().getParcelableExtra(ExtraConstants.EXTRA_IDP_RESPONSE);

auth/src/main/res/layout/sign_in_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
/>
6565
<Button
6666
style="@style/FirebaseUI.Button"
67-
android:text="@string/button_text_next"
67+
android:text="@string/next"
6868
android:id="@+id/button_done"/>
6969
</LinearLayout>
7070
</RelativeLayout>

auth/src/main/res/layout/signin_no_password_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
>
3030
<Button
3131
style="@style/FirebaseUI.Button"
32-
android:text="@string/button_text_next"
32+
android:text="@string/next"
3333
android:id="@+id/button_ok"
3434
/>
3535
</LinearLayout>

auth/src/main/res/layout/welcome_back_idp_prompt_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@
2626
android:layout_width="wrap_content"
2727
android:layout_height="wrap_content"
2828
android:layout_gravity="end"
29-
android:text="@string/welcome_back_idp_button" />
29+
android:text="@string/sign_in" />
3030

3131
</LinearLayout>

auth/src/main/res/layout/welcome_back_password_prompt_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
/>
5959
<Button
6060
style="@style/FirebaseUI.Button"
61-
android:text="@string/button_text_sign_in"
61+
android:text="@string/sign_in"
6262
android:id="@+id/button_done"/>
6363
</LinearLayout>
6464
</LinearLayout>

auth/src/main/res/values/strings.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
<string name="app_name">ui_flow</string>
33
<string name="email_hint">Email</string>
44
<string name="sign_in_no_password_title">Put an email to use for sign in</string>
5-
<string name="button_ok_text">OK</string>
65
<string name="password_hint">Password</string>
7-
<string name="button_singin_text">Sign In</string>
86
<string name="button_password_recovery_text">Trouble remembering your password</string>
97
<string name="name_hint">First &amp; last name</string>
108
<string name="password_recovery_title">Forgot password</string>
@@ -16,10 +14,8 @@
1614
and numbers</string>
1715
<string name="invalid_email_address">That email address isn\'t correct</string>
1816
<string name="missing_email_address">Enter your email address to continue</string>
19-
<string name="button_text_next">Next</string>
2017
<string name="button_text_send">Send</string>
2118
<string name="button_text_save">Save</string>
22-
<string name="button_text_sign_in">Sign in</string>
2319
<string name="require_email_text">Please input email address</string>
2420
<string name="confirm_recovery_body">Follow the instructions sent to %1$s to recover your
2521
password.</string>
@@ -31,7 +27,6 @@
3127
<string name="next">Next</string>
3228
<string name="trouble_signing_in">Trouble signing in?</string>
3329
<string name="sign_in">Sign in</string>
34-
<string name="sign_in_title">Sign in</string>
3530
<string name="sign_in_with_google">Sign in with Google</string>
3631
<string name="sign_in_with_facebook">Sign in with Facebook</string>
3732
<string name="button_done">Done</string>
@@ -42,7 +37,6 @@
4237
You\'ve already used <xliff:g id="email_addr" example="[email protected]">%1$s</xliff:g>.
4338
Sign in with <xliff:g id="provider_name" example="Google">%2$s</xliff:g> to continue.
4439
</string>
45-
<string name="welcome_back_idp_button">Sign in</string>
4640
<string name="welcome_back_password_prompt_body">You\'ve already used
4741
<xliff:g id="email_addr" example="[email protected]">%1$s</xliff:g> to sign in. Enter
4842
your password for that account.</string>

0 commit comments

Comments
 (0)