Cleanup strings.xml: removed duplicates, Google sign in button now us… #245
Conversation
…ing default Google Play Services text.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
2016-08-09 21:52 GMT+02:00 googlebot [email protected]:
|
|
CLAs look good, thanks! |
| @@ -1,6 +1,6 @@ | |||
| <Button | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| style="@style/FirebaseUI.Button.AccountChooser.GoogleButton" | |||
| android:text="@string/sign_in_with_google" | |||
| android:text="@string/common_signin_button_text_long" | |||
There was a problem hiding this comment.
Where is this defined, in Google Play Services? I don't see it in strings.xml. If it's defined in a dependency let's re-define it here so we don't get changing text over time, the string resources of Google Play Services are not considered a public API and may change or go away.
|
@peterhav one comment, otherwise LGTM. |
Reverted remove of Google Sign In button string
Reverted to use string value from auth strings.xml and not from a dependency
|
LGTM, thanks! |
Changes as discussed in issue #242, please verify @samtstern