Skip to content

Commit c8b5ed9

Browse files
committed
Fix test failures by working around Facebook SDK
Change-Id: If1686bde8906f2e06d87c51fb8399be0b960028d
1 parent 2217102 commit c8b5ed9

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

auth/src/test/java/com/firebase/ui/auth/testhelpers/CustomCountDownTimerShadow.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ public class CustomCountDownTimerShadow {
1111
private boolean started;
1212
private long countDownInterval;
1313
private long millisInFuture;
14-
@Mock
15-
public static CountDownTimer countDownTimer;
1614

15+
@Mock
16+
public CountDownTimer countDownTimer;
1717

1818
public CustomCountDownTimerShadow() {
1919
}

auth/src/test/java/com/firebase/ui/auth/testhelpers/FacebookProviderShadow.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
package com.firebase.ui.auth.testhelpers;
1616

17+
import android.app.Activity;
1718
import android.support.annotation.StyleRes;
1819

1920
import com.facebook.login.LoginResult;
@@ -47,6 +48,10 @@ public FacebookProviderShadow() {
4748
@SuppressWarnings("checkstyle:methodname")
4849
public void __constructor__(AuthUI.IdpConfig idpConfig, @StyleRes int theme) {}
4950

51+
public void startLogin(Activity activity) {
52+
onSuccess(null);
53+
}
54+
5055
@Implementation
5156
public void setAuthenticationCallback(IdpCallback idpCallback) {
5257
mCallback = idpCallback;

auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import android.widget.Button;
2020
import android.widget.LinearLayout;
2121

22-
import com.facebook.FacebookSdk;
2322
import com.firebase.ui.auth.AuthUI;
2423
import com.firebase.ui.auth.BuildConfig;
2524
import com.firebase.ui.auth.R;
@@ -132,7 +131,6 @@ public void testFacebookLoginFlow() {
132131
List<String> providers = Arrays.asList(AuthUI.FACEBOOK_PROVIDER);
133132

134133
AuthMethodPickerActivity authMethodPickerActivity = createActivity(providers);
135-
FacebookSdk.sdkInitialize(authMethodPickerActivity);
136134

137135
Button facebookButton = (Button) authMethodPickerActivity.findViewById(R.id.facebook_button);
138136
assertNotNull(facebookButton);

0 commit comments

Comments
 (0)